Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass depth down to git clone in order to correctly diff the changes #513

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Sep 5, 2018

This now checks the list of commits on the push and passes this + 1 as depth down to the cloning support in order to be able to correctly determine the list of changed files.

This fixes #481, #328, #293

@cdupuis cdupuis changed the title Autofix: tslint Pass depth down to git clone in order to correctly diff the changes Sep 5, 2018
@cdupuis cdupuis added changelog:fixed Add this issue or pull request to fixed changelog section auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge labels Sep 5, 2018
@cdupuis
Copy link
Member Author

cdupuis commented Sep 5, 2018

@jessitron, please wait with reviewing this. I might have more to fix issues for this on non-master branches.

@jessitron
Copy link
Contributor

oh wow this is really clever

@cdupuis cdupuis merged commit b004de2 into master Sep 7, 2018
@cdupuis cdupuis deleted the clone-depth branch September 7, 2018 08:02
atomist-bot added a commit that referenced this pull request Sep 7, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:fixed Add this issue or pull request to fixed changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material changes not seen as material changes
2 participants